-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(meetings): add ability to reclaim host role with hostKey #3291
Conversation
This pull request is automatically being deployed by Amplify Hosting (learn more). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one small suggestion
* @param {RoleAssignmentOptions} options | ||
* @returns {RoleAssignmentRequest} the request parameters (method, uri, body) needed to make a addMember request | ||
*/ | ||
MembersUtil.getRoleAssignmentMemberRequestParams = (options: RoleAssignmentOptions) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that beta branch has return type RoleAssignmentRequest, but that is not specified in this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this @nataliadelmar
COMPLETES # SPARK-486926
This pull request addresses
The need to be able to reclaim the host role by any other participant in the meeting. This is especially useful in meetings where hosts of the meeting don't join and one of the guests has to take up the role of a host.
Refer #3272 and #3289 for the same functionality being added in the
beta
branch. This needed to be done in themaster
branch due to the release of USM.Confluence document for reclaiming host.
by making the following changes
Change Type
The following scenarios where tested
I certified that
I have read and followed contributing guidelines
I discussed changes with code owners prior to submitting this pull request
I have not skipped any automated checks
All existing and new tests passed
I have updated the documentation accordingly
Test Results
plugin-meetings
members
...
#assignRoles
✔ should not make a request if there is no member id
✔ should not make a request if there is no locus url
✔ should not make a request if locus throws ReclaimHostNotSupportedError
✔ should not make a request if locus throws ReclaimHostNotAllowedError
✔ should not make a request if locus throws ReclaimHostEmptyWrongKeyError
✔ should not make a request if locus throws ReclaimHostIsHostAlreadyError
✔ should not make a request if locus throws a different error
✔ should make the correct request when called with roles
...
plugin-meetings
members utils library
#generateRaiseHandMemberOptions
✔ returns the correct options
#generateLowerAllHandsMemberOptions
✔ returns the correct options
#getAddedRoleShape
✔ returns the correct shape with hostkey
✔ returns the correct shape without hostkey
#getRoleAssignmentMemberRequestParams
✔ returns the correct request params
✔ returns the correct request params with a hostKey
Result
914 passing (2m)
11 pending
3 failing
TurnDiscovery
doTurnDiscovery
resolves with undefined if the response does not have all the headers we expect:
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\sreenara\stuff\webex-js-sdk\packages@webex\plugin-meetings\test\unit\spec\roap\turnDiscovery.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)
TurnDiscovery
doTurnDiscovery
resolves with undefined if the response does not have any headers:
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\sreenara\stuff\webex-js-sdk\packages@webex\plugin-meetings\test\unit\spec\roap\turnDiscovery.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)
TurnDiscovery
doTurnDiscovery
resolves with undefined if the response has empty headers array:
Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\Users\sreenara\stuff\webex-js-sdk\packages@webex\plugin-meetings\test\unit\spec\roap\turnDiscovery.ts)
at listOnTimeout (node:internal/timers:559:17)
at processTimers (node:internal/timers:502:7)
Make sure to have followed the contributing guidelines before submitting.